xemle / home-gallery

Self-hosted open-source web gallery to view your photos and videos featuring mobile-friendly, tagging and AI powered image discovery
https://home-gallery.org
MIT License
836 stars 64 forks source link

Initial faces work #132

Open dukobpa3 opened 7 months ago

dukobpa3 commented 7 months ago

Update couple icons. Screenshot 2024-04-08 at 12 55 33 Screenshot 2024-04-08 at 12 55 40

Update years layout

Was: Screenshot 2024-04-08 at 12 59 43

Became:

https://github.com/xemle/home-gallery/assets/1858880/129b5822-2f09-4907-b610-ce656b821cd7

Clickable names in details view: Screenshot 2024-04-08 at 12 55 56

dukobpa3 commented 7 months ago

Screenshot 2024-04-08 at 14 53 25

xemle commented 3 months ago

Hi @Dukobpa3

I am happy to announce the first experimental plugin feature in the current master! See docs.home-gallery.org/plugin for further details!

xemle commented 2 months ago

@Dukobpa3 what are the status of this PR? Are you still working on it?

dukobpa3 commented 1 month ago

Have been not working on it for a while. Was a lot of personal and job tasks. And now I see there a lot of conflicts but also new architecture. Will look on it soon :)

dukobpa3 commented 1 month ago

@xemle

I see the work with plugins should be better with logical parts, but not understand how to do something with UI in this architecture. Any plugin will provide some additional info which should be shown somewhere? How?

xemle commented 1 month ago

@Dukobpa3 welcome back! Awesome that you are continuing.

And yes, there are some changes in favor of the plugin system. And also true for UI changes there is no plugin support yet. Only Extractor (server side), Database Builder (server side) and Query (server side and browser) is supported.

The UI is missing but I have prototypes and a PoCs. Most probably it will be done via WebComponents which can be hooked to some UI places like the detail view.

Up to now there is no discussion or request regarding plugins and I will add them if this changes. We can have discussions about the plugins (architecture) on the discord channel (finally there is one, thanks again ;-) )

dukobpa3 commented 1 month ago

As soon as your app doesn't have much UI I think each plugin just can't expose couple components like: — main ui button — under view button — details panel (like widget which can be added to details view stack)

Any other popups and views I think can be managed from plugin side

Something like that 🤷‍♂️

xemle commented 1 month ago

Are you interessted in a UI plugin to finalize the face tagging? If so, I will try to focus on that feature in the next steps.

Currently I am looking for a usecase where the UI plugin could be demonstrated. Maybe we can use your feature to implement as pure plugin? Would you be interested?

Otherwise you could implement it into the app and it could be extracted later as plugin

dukobpa3 commented 1 month ago

Right now I've just coptpasted "tags" and made "faceTags" beside

Not much like this idea, so if there will be some UI plugin system I think everything become cleaner not only in case of faces.