search

xemlock / htmlpurifier-html5

HTML5 support for HTMLPurifier
https://packagist.org/packages/xemlock/htmlpurifier-html5
MIT License
101 stars 12 forks source link

Added masterminds/html5 #52

Closed bytestream closed 4 years ago

bytestream commented 4 years ago

Ability to switch to masterminds/html5 lexer for better HTML5 support using:

$config = \HTMLPurifier_HTML5Config::create();
$config->set('Core.LexerImpl', new \HTMLPurifier_Lexer_HTML5);
bytestream commented 4 years ago

Thanks for the quick feedback :+1: should all be updated

bytestream commented 4 years ago

No worries :) - all done

xemlock commented 4 years ago

@bytestream Thanks a lot for this contribution. Expect it to be published before the end of the year, as there is some other stuff I want to include in the upcoming release.

bytestream commented 4 years ago

@xemlock Happy to help! No rush on the release.

bytestream commented 4 years ago

@xemlock any chance of movement on this, and my comment on the active issues?

bytestream commented 4 years ago

@xemlock your response would be appreciated. Add me as collab. I'm happy to help if this lib is now no longer being maintained...

xemlock commented 4 years ago

Hi @bytestream, I'm really sorry for not responding to your messages. I had a tough last few weeks (months?), and I couldn't find enough time to address this issue. In about a week I expect to have more spare time, so I will then give it a thought how it should be implemented.

Oh, this lib is still maintained, security issues have the highest priority (so far there were none in last few months) and are resolved ASAP, but feature requests have to wait.

bytestream commented 4 years ago

@xemlock Your response is much appreciated.

Would you mind just releasing this PR given it's fully BC and not used by default?

The other stuff can wait until you have more time available to discuss it.