Add contenteditable to CommonAttributes

xemlock / htmlpurifier-html5

HTML5 support for HTMLPurifier

https://packagist.org/packages/xemlock/htmlpurifier-html5

MIT License

101 stars 12 forks source link

Add contenteditable to CommonAttributes #78

Closed bytestream closed 2 years ago

bytestream commented 2 years ago

This copies CommonAttributes changes in v4.15.0 from upstream, otherwise contenteditable="false" is not considered valid on HTML5 doc types.

It also bumps the requirements to match ezyang/htmlpurifier in v4.15.0

bytestream commented 2 years ago

@xemlock this OK?

xemlock commented 2 years ago

Hi @bytestream, yes it should suffice. Thanks!

xemlock commented 2 years ago

I've just noticed that versions matrix has been modified. So after a bit of thought, I'm in strong favor of adding our own, in-library definition for this attribute, to avoid impacting dependency versions.

xemlock commented 2 years ago

Superseded by #79.