xemu-project / xemu

Original Xbox Emulator for Windows, macOS, and Linux (Active Development)
https://xemu.app
Other
2.57k stars 258 forks source link

"Created new snapshot" notification may appear when it was not actually created #1670

Open mborgerson opened 2 weeks ago

mborgerson commented 2 weeks ago

Bug Description

If xemu is not fully configured and is just sitting idle, and the user uses the popup menu to create a snapshot the following notification will be displayed:

image

Expected Behavior

An error message should have been displayed. The user probably should have also not been able to click the button in the first place because of the application state.

xemu Version

v0.7.127

System Information

N/A

Additional Context

Unconditional notification queue:

https://github.com/xemu-project/xemu/blob/b4ce2b58d09baa6dfd17c0bcab2e505df9f310e4/ui/xui/popup-menu.cc#L378