xemwebe / yahoo_finance_api

Simple wrapper to yahoo! finance API to retrieve latest quotes and end-of-day quote histories
Apache License 2.0
64 stars 29 forks source link

Replace blocking client with lighter one #12

Closed nicomem closed 3 years ago

nicomem commented 3 years ago

(Based on the branch at #11, this should not be merged before the base branch)

This PR makes those changes:

xemwebe commented 3 years ago

Though I understand the demand for a lighter http client, I would prefer to have this implemented as an alternative, not as a replacement. If the library is used in context where reqwest is used anyway, which is not unlikely, since it is the most widely used http client crate, switching to another client would indeed increase the dependency burden instead of reducing it. In addition, features like compilation to WASM targets does not seem to be supported by ureq (or at least that would have to be checked first). Therefore, I am a bit reluctant to accept this PR as it is.