xemwebe / yahoo_finance_api

Simple wrapper to yahoo! finance API to retrieve latest quotes and end-of-day quote histories
Apache License 2.0
64 stars 29 forks source link

Re-export dependencies? #31

Closed andber1 closed 1 year ago

andber1 commented 1 year ago

Should the time crate be re-exported (as described here)? In order to use the function get_quote_history, e.g., I have to add the time crate on myself (because I need the OffsetDateTime struct or datetime macro). But it would be nice not to have to worry about that (not to mention finding the correct version in case of breaking changes in the time crate) and just write use yahoo_finance_api::export::time, or something similar.

xemwebe commented 1 year ago

Yes, that's a good idea. Thank your for the suggestion. I have just pushed & published this small change.