search

xen-troops / displ_be

GNU General Public License v2.0
2 stars 8 forks source link

Private methods should be static #130

Closed iusyk closed 3 years ago

iusyk commented 4 years ago

Add 'const' and 'static' to some methods.

The methods are not using the class members or methods must be declared as static, there are ConnectorBase::edidPutDetailedTimin ConnectorBase::edidPutTimings ConnectorBase::edidPutColorSpace ConnectorBase::edidPutEssentials ConnectorBase::edidPutBlockCheckSum

The memebrs that are const must be static There are ConnectorBase::EDID_MANUFACTURING_YEAR ConnectorBase::EDID_DPI ConnectorBase::EDID_REFRESH_RATE_HZ

The methods to return the value and not modify the object state, must be 'const'. There are Connector::getEDID

The ConnectorBase::edidPutTimings has been modified to support 'const' for Connector::getEDID.

Signed-off-by: Ihor Usyk ihor_usyk@epam.com Reviewed-by: Volodymyr Babchuk volodymyr_babchuk@epam.com

lorc commented 3 years ago

Reviewed-by: Volodymyr Babchuk <volodymyr_babchuk@epam.com>