xen-troops / meta-xt-prod-devel-rcar

Main Xen Troops product, which is used for day-to-day development and integration
Apache License 2.0
4 stars 14 forks source link

Miscellaneous changes to yamls #112

Closed rshym closed 10 months ago

rshym commented 11 months ago
otyshchenko1 commented 11 months ago

First and last commit - Reviewed-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com> With https://github.com/xen-troops/meta-xt-prod-devel-rcar/pull/112/commits/eb318eb94bc3bac7583bd8373d36ba4065f2b799 applied, some hard-coded names are still present (I noticed for generic-armv8-xt and xenvm). Or this is by intention?

rshym commented 10 months ago

RB is added to the first and the last commits.

Instances of the generic-armv8-xt are replaced with DOM0_MACHINE (in devel and virtio files). Two instances of the xenvm strings in DomA related parts are kept as is intentionaly, because IMO they are not linked directly to ANDROID_DEVICE. Also, I have checked a similar part of the virtio.yaml, and I see a different approach (other builder and prefixes for built_target). And such change will not provide any unification of the code. So I decided to consider these xenvm just like string.

agl-related yaml is updated accordingly.

rshym commented 10 months ago

Rebased to the latest master branch.

rshym commented 10 months ago

Ack and RB were added. Smoke-tested.

rshym commented 10 months ago

PR was successfully built on the local host with the following commands:

moulin prod-devel-rcar.yaml --MACHINE h3ulcb-4x2g --ENABLE_DOMU yes
ninja full.img
lorc commented 10 months ago

Looks like there are conflicts after the last merge. Could you please fix them?

rshym commented 10 months ago

Rebased on the latest master branch. Conflicts are solved.