search

xen-troops / meta-xt-prod-devel

GNU General Public License v2.0
4 stars 13 forks source link

domd: Allow overwrite KERNEL_DEVICETREE variable #370

Open varder opened 3 years ago

varder commented 3 years ago

KERNEL_DEVICETREE variable is used to generate the symbolic link for the current domain. According to the current code the link will point to the file which is at the end of the list of the variable. But when a user specifies a device tree for a specific machine the the link will still be pointing to the generic one.

Signed-off-by: Valerii Chubar valerii_chubar@epam.com

rshym commented 3 years ago

Another possible solution for this issue - user can prepend his (her) DTB to KERNEL_DEVICETREE.

rshym commented 3 years ago

This PR revealed three issues with the modified receipt. 1) We add DTB for all guests (doma and domu) in all products - maybe this needs to be fixed. 2) We use double dash -- inside the name of DTB (salvator-generic-domu--5.10.0+git0*.dtb). Is it intentionally or just a misprint? 3) Maybe we need to put a comment in this receipt, with an explanation of how to provide custom DTB? I mean that it needs to be prepended or appended. Just for the future.

rshym commented 3 years ago

Sorry, these issues are not addressed to the author of PR.

rshym commented 3 years ago

Seems that this PR may be merged but it needs comment in sources like this

# If you need to add custom DTB for a guest domain, then use KERNEL_DEVICETREE_append
# to overwrite generic guest file.