search

xen-troops / meta-xt-prod-devel

GNU General Public License v2.0
4 stars 13 forks source link

domd: net: Make network settings according to guest installed #376

Closed rshym closed 3 years ago

rshym commented 3 years ago

This change removes not related records made to dnsmasq.conf and port-forward-systemd-networkd.conf.

Signed-off-by: Ruslan Shymkevych ruslan_shymkevych@epam.com

lorc commented 3 years ago

It would be great to have some sort of array/table where you can define all the guest network settings. This will minimize code duplication.

But I don't see an easy way to implement this in sh scripts. So I'm okay with the current approach.

Reviewed-by: Volodymyr Babchuk <volodymyr_babchuk@epam.com>

rshym commented 3 years ago

Reviewer is added. Successfully tested by inspection of corresponding files dnsmasq.cof and port-forward-systemd-networkd.conf after the build for doma and domu.