Closed dsemenets closed 7 months ago
I believe you mistaken this issue with #100
I believe you mistaken this issue with #100
No. I have updated this PR
Could you please elaborate what exactly your change does? It is hard to tell from the diff itself.
Could you please elaborate what exactly your change does? It is hard to tell from the diff itself.
Fetcher creates directory 'build_dir' and fetch repository there. My changes moves config file for script and working directory to the 'build_dir'
I am curious if it will break existing scripts.
@Mishytca, @al1img, @svlad-90, AFAIR some of you are using this feature. Could you please check if this PR breaks your use case? It basically changes CWD for the script and this may or may not affect your scripts
Hi @lorc, I've performed the following steps:
The result of the build is successful. So, I guess, you can merge it.
Thanks!
Acked-by: Volodymyr Babchuk <volodymyr_babchuk@epam.com>
@dsemenets please rebase this PR
@lorc I have added one more patch to fix tests. Please review
Could you please rearrange the commits so fix for test comes first and then change to "custom_script". This is to ensure that git bisect
will behave correctly.
With that:
Acked-by: Volodymyr Babchuk <volodymyr_babchuk@epam.com>
Actually this PR consists only one commit https://github.com/xen-troops/moulin/pull/104/commits/7a3cfa109c0e59369f633a6b87c498164f778857 Remain commits reviewed in PR https://github.com/xen-troops/moulin/pull/103