Closed akhuettel closed 2 years ago
Hi, thanks for the review!
Re the package.use
and package.accept_keywords
directories, sorry for not explaining this upfront: they are purely for convenience, and are not meant to be pushed as-is. At the very least, all package_accept_keywords
entries are to be converted into keywords on actual ebuilds, so none of them should end up in ::gentoo
.
Also, for the dev profile part, I already forgot the exact reason why I chose dev
for the profiles initially, but it may be because I wanted to make repoman -d
work. I agree full exp
would be better, as long as exp profiles still get checked by CI.
The other tweaks look good to me; I'll merge the last two for now. I'm working on a PR to ::gentoo
which I'll publish later today.
Merged the whole loong-profile-restructure
branch into master, because I've successfully built stages with the branch.
Upstreaming PR: https://github.com/gentoo/gentoo/pull/25083 (This is stripped even more; some tweaks like the systemd profiles' make.defaults
are likely warts of my bootstrapping that aren't actually necessary. We'll see.)
Hi,
I went through the files and it looks very good. Here are some minor (mostly cosmetic / obscure rules) changes... With this we can import the profile tree soon I think!
Cheers, Andreas