Hotfix 104

[ArtemConstantinov]

Apply hotfix for rel v1.0.4

[fpfeng]

Can confirm it is working good with main branch of 2889 and latest xoa-converter.

[ArtemConstantinov]

Didn't we agree that the dependency on xoa-driver should be 1.0.14/1.0.15? But I can see that the version of xoa-driver is restricted to 1.0.12.

I get confused based on the issue10 brunch, so I copy it from there. Because we agreed not to specify the fixed version in setup.py file and instead to have more clear instructions for dependencies required in the doc section before example code.

I think we just can to remove it or to keep as a minimal compatible version.

[MaureenChan]

Can confirm it is working good with main branch of 2544 and latest xoa-converter.

[leonardhyu]

@ArtemConstantinov @fpfeng @MaureenChan Could you check whether our 2544 and 2889 and this core works also with xoa-driver>=1.0.14? This is because we have fixed a bug in 1.0.14 https://github.com/xenanetworks/open-automation-python-api/pull/56 🥲 🙏

• with 1.0.12<=xoa-driver<1.0.14 has a bug in itself that causes parsing to fail.

• with xoa-driver>1.0.14, no parsing bug but p_capabilities is changed

[fpfeng]

Test passed for driver >= 1.0.14 with live demo chassis, fail with local chassis maybe because it is not update yet, meet P_CAPABILITIES error. xoa_driver.internals.core.protocol.struct_response.NotEnoughBytesLeft: When parsing P_CAPABILITIES, there are still fields ['traffic_engine', 'reconc_sublayer'] to be parsed while there is no more bytes!

[fpfeng]

The conflict is caused by:
    The user requested xoa-driver==1.0.14
    xoa-core 1.0.7 depends on xoa-driver==1.0.12

To fix this you could try to:
1. loosen the range of package versions you've specified
2. remove package versions to allow pip attempt to solve the dependency conflict

  Running command git clone --filter=blob:none --quiet https://github.com/xenanetworks/open-automation-config-converter.git /tmp/pip-req-build-oz3joxpm
  Running command git clone --filter=blob:none --quiet https://github.com/xenanetworks/open-automation-core.git /tmp/pip-req-build-nssslg9b
  Running command git checkout -b hotfix_104 --track origin/hotfix_104
  Switched to a new branch 'hotfix_104'
  Branch 'hotfix_104' set up to track remote branch 'hotfix_104' from 'origin'.
ERROR: Cannot install xoa-core==1.0.7 and xoa-driver==1.0.14 because these package versions have conflicting dependencies.
ERROR: ResolutionImpossible: for help visit https://pip.pypa.io/en/latest/topics/dependency-resolution/#dealing-with-dependency-conflicts

driver1014-coregit-convertergit: exit 1 (9.88 seconds) /home/chf/xena/xoa_integration_test> python -I -m pip install pytest pytest-asyncio pytest-sugar xoa-driver==1.0.14 git+https://github.com/xenanetworks/open-automation-config-converter.git@main git+https://github.com/xenanetworks/open-automation-core.git@hotfix_104 pid=19650
  driver1012-coregit-convertergit: OK (65.66=setup[0.02]+cmd[65.64] seconds)
  driver1014-coregit-convertergit: FAIL code 1 (9.88 seconds)
  evaluation failed :( (75.58 seconds)

Some test result while I playing tox.

[leonardhyu]

Test passed for driver >= 1.0.14 with live demo chassis, fail with local chassis maybe because it is not update yet, meet P_CAPABILITIES error. xoa_driver.internals.core.protocol.struct_response.NotEnoughBytesLeft: When parsing P_CAPABILITIES, there are still fields ['traffic_engine', 'reconc_sublayer'] to be parsed while there is no more bytes!

As long as core 1.0.7 is compatible with driver 1.0.15, we are good. Thanks @fpfeng for testing this. We can release core 1.0.7 now

[leonardhyu]

Blocked by https://github.com/xenanetworks/open-automation-test-suites/issues/12 since I need to tell users how to tell the test result type.