xenanetworks / open-automation-rfc-test-suites

🚀 XOA test suite library for network performance benchmarking and more.
https://docs.xenanetworks.com/projects/xoa-core
Apache License 2.0
2 stars 1 forks source link

Should use TX TIME LIMIT instead of PACKET LIMIT to control test duration #49

Open leonardhyu opened 11 months ago

leonardhyu commented 11 months ago

Discovered a bug in xoa2889 where it uses P_TXPACKETLIMIT to control the test duration. This leads to a similar problem in xoa2544 that when the port speed is high, packet size is small, and duration is large, the packet count value can explode the limit of what P_TXPACKETLIMIT/PS_TXPACKETLIMIT allows. For example, using a 100G port with 64-byte frame size, 30 seconds duration will result in about 4400 million packet, way off the limit of the 32-bit signed integer of the BXMP command.

In 2544, we have stopped using packet limit to control test duration, but only uses time limit. Could you also change 2889 in the same way?

fpfeng commented 11 months ago

1690950752919 those port rate limit options was base on calculated packets limit, can i convert all of them base on rate fraction? @leonardhyu

leonardhyu commented 10 months ago

@fpfeng I don't get the question. Let's talk about it in the meeting tmr.