xendit / xendit-magento-payment-module

module for customer integration through magento
GNU General Public License v3.0
6 stars 4 forks source link

Fix cryptic callback response message when IP hasn't been whitelisted #166

Closed danilhendrasr closed 1 year ago

danilhendrasr commented 1 year ago

Description

When receiving callback, if the user's server IP address hasn't been whitelisted, Xendit will get back cryptic error message that doesn't show what's wrong:

image 3

One has to dig through the code, adding logs manually, to find the root issue:

image 1

The process of finding the root cause can be unnecessarily time consuming. With this PR if the user's server IP hasn't been whitelisted upon receiving callback, Xendit will get back a clear response message pointing out what's wrong:

image 2

Thus users have clear indication of what's wrong just by inspecting the callback log from Xendit dashboard.

Type of change

Checklist

yanoandri commented 1 year ago

Hi @danilhendrasr thank you for raising this, will merge this PR to solve the issues, thank you for improving our Magento plugins