search

xendit / xendit-php

Xendit REST API Client for PHP - Card, Virtual Account, Invoice, Disbursement, Recurring Payments, Payout, EWallet, Balance, Retail Outlets Services, xenPlatforms
https://developers.xendit.co/api-reference/
MIT License
153 stars 76 forks source link

hotfix query in GET method #148

Closed David-Kurniawan closed 2 years ago

David-Kurniawan commented 2 years ago

Got the critical issue when we use GET method and pass the query parameters. query do not pass in guzzle side coz default library process the params to transform into json. But in GET method, we need to transform params into query not json.

eg is: 

$params = [
    'types' => 'DISBURSEMENT'
];

$transactions = \Xendit\Transaction::list(array $params);

the params is not working cos Transaction::list using GET method and params tranform into json not into query

David-Kurniawan commented 2 years ago

@xen-HendryZheng can help me to review this PR

Need to solving this critical issue ASAP

Thanks