search

xendit / xendit-php

Xendit REST API Client for PHP - Card, Virtual Account, Invoice, Disbursement, Recurring Payments, Payout, EWallet, Balance, Retail Outlets Services, xenPlatforms
https://developers.xendit.co/api-reference/
MIT License
152 stars 76 forks source link

Addition of PHP Test Pipeline #213

Closed tolik518 closed 10 months ago

tolik518 commented 10 months ago

Description

This PR introduces a new file, php-test.yml, to the repository. This file is designed to execute tests in the CI/CD pipeline, on every Push and PR, enhancing the robustness and reliability of the codebase.

Although the repository currently only contains placeholder tests, the addition of this pipeline is a proactive measure to ensure that any future tests can be automatically run for PHP versions 7.4, 8.0, 8.1, and 8.2. This will help to maintain the quality of the code and identify any potential issues early in the development process.

Changes

Impact

This change will not affect the current functionality of the codebase, but it will provide a framework for automated testing in the future. It will also encourage the addition of tests to the repository, promoting a test-driven development approach.

Future Work

Moving forward, we should aim to add meaningful tests to the repository to fully utilize this pipeline and ensure the stability and reliability of the codebase.

adityarx commented 10 months ago

Hi @tolik518 thanks for your contribution and appreciate the effort in raising this. As our SDK is generated, we are trying to minimize the specific code necessary for each language. So I'm afraid we can't support this addition to the library at this moment.

That being said, we do have some early stage ideas about how to write scalable tests across all of Xendit's languages at the moment and are working towards a Q1 2024 timeline.

Thanks again! I'd invite you to raise an issue next time so we can have a discussion prior to a PR 🙏