xendit / xendit-sdk-ios-src

MIT License
7 stars 12 forks source link

Swipe Down Dismiss Not Receiving Callbacks From AuthenticationWebViewController #28

Closed rinoarmadiaz closed 3 years ago

rinoarmadiaz commented 3 years ago

Hi Xendit Team,

i found minor issue on AuthenticationWebViewController when we're trying to call 3ds authentification.

so the issue is when we're calling Xendit.createAuthentication() for presenting a 3ds webview, we're not getting the error callback when user are trying to dismiss the presented ViewController (AuthenticationWebViewController) which triggered from @objc func cancelAuthentication()

i have two suggestion here,

either we disable swipe to dismiss the Presenting ViewController (AuthentificationWebViewController) or we call cancelAuthentification() on viewWillDissapear() so the App will know if the webview is dismissed.

i'm using version:

gif

thanks in advance!

sergioutama commented 3 years ago

@rinoarmadiaz does this PR https://github.com/xendit/xendit-sdk-ios-src/pull/29 fix the issue ?

rinoarmadiaz commented 3 years ago

presentationControllerDidDismiss() should work, thanks for the fix 👍🏻

javiersuweijie commented 3 years ago

31 & #29

has been merged