[Cards] Bug: iOS SDK card expiry validation is hardcoded

xendit / xendit-sdk-ios-src

MIT License

7 stars 12 forks source link

[Cards] Bug: iOS SDK card expiry validation is hardcoded #77

Open zakiarsyad opened 6 months ago

zakiarsyad commented 6 months ago

context:

https://xendit.slack.com/archives/C06L0DLT48Z/p1716458994957289?thread_ts=1716431731.182719&cid=C06L0DLT48Z
The iOS SDK card expiry validation is hard coded to 2017 --> https://github.com/xendit/xendit-sdk-ios-src/blob/a23b39f06818a1e48a90197eb997bffe268cc5b0/Sources/Xendit/Utils/CreditCard.swift#L47
It is not reflected in the current year

task:

Update the validation to be relevant with current year and the future

zakiarsyad commented 6 months ago

It also happens to Android

https://github.com/xendit/xendit-sdk-android/blob/11cb3a5f9f8a6eee848377795e144538d404c8d8/xendit-android/src/main/java/com/xendit/utils/CardValidator.java#L75

lordrio commented 6 months ago

this bug does not happen on Android to an extra function of isNotInThePast(cleanMonth, cleanYear); But still a good practice to remove any hardcoded text.