xenesty / AkashaScanner

A Genshin Impact tool to export achievements, characters, artifacts, and weapons.
MIT License
81 stars 9 forks source link

Issue detecting certain achievements (stamps marked with "Total: X") #23

Open ScorelessPine opened 1 year ago

ScorelessPine commented 1 year ago

Describe the bug Issue detecting completed non-standard achievement stamps

To Reproduce Use achievement scanner (1600x900 game window resolution chosen) Some achievements are improperly marked as incomplete.

Expected behavior Achievements such as Purveyor of Punishment, and any others that have an achievement entry similar to what is shown in the below screenshot, should be marked as complete rather than not.

Screenshots After a scan, the number of achievements completed does not match. image

After importing data into Paimon.moe, these achievements and more are all unmarked, all of which seem to have the "Total: X" on the stamp on the right-hand side. image

Additional context Add any other context about the problem here. I would believe if the issue could be related to the fact that some game UI elements are positioned differently after resizing the window than they would be if the game launched at that resolution instead. For example, below shows two screenshots of the Character screen and how the arrow is positioned. The first is when you resize the game from 3440x1440 to 1600x900, and the second is when launching the game at 1600x900. I have not personally tested if this makes a difference in achievement scans, however it is worth looking into. First image of resized 3440x1440 - 1600x900 image

Second image of launching the game at 1600x900 image

Note how much less space there is between the edge of the game screen and the arrow in the second image.

ScorelessPine commented 1 year ago

And boy have i made a fool of myself, after running it one more time without having changed the resolution after launching, it did actually get the correct value. However I do still believe this is valuable information that should be added to the readme: If you change your resolution, you must restart the game entirely before running the achievement scanner or it will return incorrect results.