search

xenharmonic-devs / scale-workshop

Design and visualize microtonal scales and play them in your web browser. Export your scales for use with VST instruments. Convert Scala files to various tuning formats.
MIT License
79 stars 11 forks source link

UI: Make checkbox gaps slightly wider #644

Closed frostburn closed 4 months ago

frostburn commented 4 months ago

Some of the <label> elements have explicit space characters in them. This doesn't look neat in template code. The gap should be controlled by CSS alone.

frostburn commented 4 months ago

Assigning to Marc in reference to https://github.com/xenharmonic-devs/scale-workshop/pull/642/files#r1562023627 .

000masa000 commented 4 months ago

copying the comment to contoinue discussion here: for now in main.css I replaced "select-group" with "dropdown-group" and also added "checkbox-group" to match the already existing "radio-group". Not sure but it seemed to make sense that a row of each of these HTML elements might need different spacing. Any thoughts about best way to implement this?

000masa000 commented 4 months ago

what class name should be given to labels that fall to the right of an input (checkbox, radio button, number) : these need a gap to the left of the text?

frostburn commented 4 months ago

what class name should be given to labels that fall to the right of an input (checkbox, radio button, number) : these need a gap to the left of the text?

I don't think they need a name. CSS rules should be able to specify label elements within a checkbox container.

frostburn commented 4 months ago

PR was #654