search

xenharmonic-devs / scale-workshop

Design and visualize microtonal scales and play them in your web browser. Export your scales for use with VST instruments. Convert Scala files to various tuning formats.
MIT License
79 stars 11 forks source link

multichannel-to-equave implemented #649

Closed 000masa000 closed 4 months ago

000masa000 commented 4 months ago

implemented changes suggested by frostburn and recoded over here as a feature branch. Hope I correctly updated to the current commits in main.

frostburn commented 4 months ago

npm run format please.

frostburn commented 4 months ago

I don't think the MIDI color mapping stuff makes sense with multichannel devices that don't have a piano layout. Maybe they should be ignored in multichannel mode.

frostburn commented 4 months ago

Overall seems good. Can't really test the functionality due to lack of hardware.

000masa000 commented 4 months ago

working with my lumatone

frostburn commented 4 months ago

Approved. Feel free to merge after fixing the minor issues.

frostburn commented 4 months ago

When merging. Use the squash option to create a single commit with these changes.