search

xenharmonic-devs / sonic-weave

The SonicWeave DSL for manipulating musical frequencies, ratios and equal temperaments
MIT License
4 stars 4 forks source link

Replace C-style comments with nestable OCaml-style comments #332

Closed frostburn closed 1 month ago

frostburn commented 1 month ago

ref #330

frostburn commented 1 month ago

@osmiumic You might want to take a look as well.

osmiumic commented 1 month ago

i dont understand github very well so i dont know how bad (or not) their search functionality is, but after this is merged i'd recommend looking for all instances of // to see if there's any single-line comments that havent been converted

also relevant: an idea i suggested before: warn users who use 2 or more /s that these are not comments but rather lifts (which could could also serve as a way of catching anything missed potentially, assuming that all SonicWeave code in the repo/in general is compiled at some stage)