search

xenharmonic-devs / xen-midi

Free-pitch polyphonic MIDI I/O based on webmidi.js using multi-channel pitch-bend
MIT License
4 stars 1 forks source link

Identify notes by channel in order to trigger overlapping note-offs #7

Closed frostburn closed 3 months ago

frostburn commented 3 months ago

ref #6

frostburn commented 3 months ago

This should come with tests to verify that the solution works, but we haven't configured vitest or the corresponding mocks yet so I'll do that separately.

frostburn commented 3 months ago

I thought it more friendly to add vitest here, so that you can merge the PR when most convenient in terms of rebasing.

000masa000 commented 3 months ago

I tested with the Lumatone sending on multiple channels and it seems to work, code looks good to me.