changed noteIdentifier range to fall between 0 and 2047

xenharmonic-devs / xen-midi

Free-pitch polyphonic MIDI I/O based on webmidi.js using multi-channel pitch-bend

MIT License

4 stars 1 forks source link

changed noteIdentifier range to fall between 0 and 2047 #9

Closed 000masa000 closed 3 months ago

000masa000 commented 3 months ago

Since webmidi.js report MIDI channels in the range 1-16 (but Web MIDI API uses 0-15) and the noteIdentifier should range from 0, I added event.message.channel - 1. This should make no difference to functionality, but I find it cleaner not to creat 128 unused indices.

frostburn commented 3 months ago

I highly recommend doing work on feature branches. main is a special branch be it in a personal repo or here. Working in main makes squashing commits together a little harder. I can squash here on GitHub though.