[3PP] Replace cpptoml with tomlplusplus

xenia-project / xenia

Xbox 360 Emulator Research Project

https://xenia.jp

Other

8.15k stars 1.12k forks source link

[3PP] Replace cpptoml with tomlplusplus #2250

Open Gliniak opened 7 months ago

Gliniak commented 7 months ago

Reasoning:

Cpptoml is obsolete.

Benefits:

toml++ is still developed and maintained.
Good documentation.
Supports UTF8 with BOM, so tricks skip BOM can be removed.

PS. Not sure if it fully works right now and I'm not sure if functions from toml_internal namespace are still required

gibbed commented 7 months ago

Oh cool. Is tomlplusplus a fork of cpptoml? The changes seem really minimal otherwise.

Gliniak commented 7 months ago

I don't know, but I agree changes are so small that it looks like a fork. I was surprised how easy it was to make it work, but I'm still not 100% sure if it works as intended. I saw that in specific cases it works differently. For example it replaces 1.0 with 1

Gliniak commented 7 months ago

I double checked it and it seems like it works flawlessly. Please review it just in case