xenia-project / xenia

Xbox 360 Emulator Research Project
https://xenia.jp
Other
8.13k stars 1.12k forks source link

Vulkan Issues / Discussion #578

Closed DrChat closed 7 years ago

DrChat commented 8 years ago

Note: Add the flag --gpu=vulkan to enable the Vulkan backend!

DrChat commented 8 years ago

@krzysztof860 - Can you attach the log file as well?

krzysztof860 commented 8 years ago

@DrChat Here you go - http://www94.zippyshare.com/v/jVNNgujm/file.html

DrChat commented 8 years ago

Neat - this looks like a new crash now.

dbz400 commented 8 years ago

thanks @DrChat

DrChat commented 8 years ago

Okay - AMD is gonna be on hold til Monday.

SakataGintokiYT commented 8 years ago

Dragon Ball Z Budokai HD Collection:

Dragon Ball Z: Budokai Tenkaichi 3 HD
Fotoszok.pl Fotoszok.pl
DBZ Budokai HD
Fotoszok.pl Fotoszok.pl
Nukem9 commented 8 years ago

I think this crash was posted before, but I can't find it right now.

http://i.imgur.com/06LFd9M.png COD4 SP @ first mission - crashes in nvidia's nvoglv64.dll

*edit: Same for skyrim.

SakataGintokiYT commented 8 years ago

[Crash] *Naruto: Rise of a Ninja Unhandled execption at 0x00000000023251fc (nvoglv64.dll)

Output : https://gist.github.com/SakataGintokiYT/d43af27cfdb52dae185e247d678673ca Log : https://gist.github.com/SakataGintokiYT/d8091e4fd51d8d8ac13b93537e566125

[Black screen ] *Naruto - The Broken Bond Output : https://gist.github.com/SakataGintokiYT/6ae2a70b347e63ca0c34f4042073635e

DrChat commented 8 years ago

AMD people - Try it again with 75908a9865b27b2eeaa21a15e3b14c9777b00d56.

sephiroth99 commented 8 years ago

Tried 9abfc52 still crashes at the same place.

I had tried the SPIR-V validator before, it did not find any issues; it is still very much a work in progress.

I will upload the newly generated shaders to the AMD thread.

DrChat commented 8 years ago

@sephiroth99 Alrighty - if you want you can take over that thread and I'll keep an eye on it.

DrChat commented 8 years ago

Neat - AMD is no longer crashing as of 14a6fd838a362031195de05a37fafd0941e689a9.

DrChat commented 8 years ago

@Gh0stblade Which games?

SakataGintokiYT commented 8 years ago

@krzysztof860 @woody2014 @Gamedev1909

Try latest build

woody2014 commented 8 years ago

Good job it`s not crashing But have a blank screen.

Gh0stBlade commented 8 years ago

@DrChat Nevermind, no crashes. Looks like Github desktop app didn't properly pull down the latest commits.

@woody2014 Same here, just black screen.

kkthxbye-code commented 8 years ago

@DrChat - Can confirm that AMD doesn't crash anymore, but that it only shows black screen. Tested Banjo and Kazooie and Bomberman. They both play audio and accept input, just no video output.

DrChat commented 8 years ago

Wonderful - Someone with experience in renderdoc, can you capture a trace and start analyzing it? Launch Xenia with renderdoc using these flags: "--flagfile=scratch/flags.txt --vulkan_primary_queue_only=true"

When in-game, press F4 to capture a trace and close Xenia after it's finished writing it.

I can't do anything with the tracefile from here, so don't upload it.

woody2014 commented 8 years ago

can we open a file in the vulkan backend then trace file.

kkthxbye-code commented 8 years ago

@Gamedev1909 - did you build it yourself? Otherwise you wont have the flags.txt file and it wont open. I managed to generate the trace, but renderdoc can't open the file, so I'm probably doing the wrong. I'm not really qualified to debug it anyway, but if you have any insight into why it wont open (says wrong magic header) @DrChat ?

DrChat commented 8 years ago

Nope. Still need someone competent to run a trace on an AMD card.

ikki84 commented 8 years ago

Tested with 16.7.2 Hotfix, still the same. Radeon R7 200

RenegadeSaiyan commented 8 years ago

So now all Xenia does with Vulkan on AMD is Crash. GG AMD

ikki84 commented 8 years ago

Tested again with Minecraft. Crashed after load the file.

-Radeon R7 200 -Driver 16.7.3 AMD Crimson Edition 28/07/2016 -Xenia build f81a99e 29/07/2016

RenegadeSaiyan commented 8 years ago

I tried some games that were proven to work, same result.

RenegadeSaiyan commented 8 years ago

I tried Sonic 2006, And Naruto Storm 2

DrChat commented 8 years ago

AMD people: I'm working on the crashes and blackscreens - be patient.

SakataGintokiYT commented 8 years ago

@DrChat

Progress :)

Fotoszok.pl Fotoszok.pl Fotoszok.pl
SakataGintokiYT commented 8 years ago

@Gamedev1909 Build from appveyor https://ci.appveyor.com/project/benvanik/xenia/build/1.0.451-master/artifacts

Gh0stBlade commented 8 years ago

@SakataGintokiYT

I get some exception here (AMD): xenia.exe!xe::gpu::vulkan::CachedRenderPass::CachedRenderPass(VkDevice_T * device, const xe::gpu::vulkan::RenderConfiguration & desired_config) Line 441 C++

Margen67 commented 8 years ago

Vulkan backend in a nutshell: https://youtu.be/68ugkg9RePc

SakataGintokiYT commented 8 years ago

@DrChat look at this : [Work around semi-broken dual-source blending on AMD.] / Dolphin https://github.com/dolphin-emu/dolphin/pull/3935/commits/e253a1673905b0b7df1fc59035b416c53b6d8d85

sephiroth99 commented 8 years ago

I think the current issue with Vulkan crash on AMD is due to this (extracted from Vulkan spec here):

Multiple attachments that alias the same memory must not be used in a single subpass

I tried to separate the 4 color attachments into 4 subpasses, and the subpass create command does not crash anymore. Now, of course the rest of the code is not made for 4 subpasses so I had other issues e.g. dependencies, but the crash is due to the single subpass I think.

krzysztof860 commented 8 years ago

Sorry for off-topic, but @DrChat someone wants to give you a R9 270X (2GB) https://www.reddit.com/r/xenia/comments/4y25ag/help_with_donating_a_gpu_to_the_xenia_devs/

MrSapps commented 8 years ago

I would assume he wants a full system, ripping out a working gpu in your own personal system with one some randomer has sent you to fix 1 issue probably isn't a great idea :s

SakataGintokiYT commented 8 years ago

@DrChat Progress !!! Xenia Vulkan build : [9457c63] _Video : https://www.youtube.com/watch?v=GUzDHodfmE4_

Fotoszok.pl
Margen67 commented 8 years ago

I hope DX12 is added anyway so the speed can be compared to Vulkan.

D1SMBD1D commented 7 years ago

All NFS games using EAGL4 (Most Wanted, Carbon and Prostreet) crash at startup on Vulkan despite being close to playable on OpenGL Here's the Carbon log for example

ikki84 commented 7 years ago

any news?

NuclearC commented 7 years ago

amd released new drivers that 'supports' glsl 4.5

Razzile commented 7 years ago

only a year or so too late lmao

ikki84 commented 7 years ago

I will update the driver and test here.

Tested: still the same results

Margen67 commented 7 years ago

@Gamedev1909 https://youtu.be/lL2ZwXj1tXM

NuclearC commented 7 years ago

anyone thinks to write D3D12 back-end for Xenia?

gibbed commented 7 years ago

The Vulkan backend is a work in progress.

NuclearC commented 7 years ago

but fcking DirectX 11 is faster than Vulkan

EDIT: here is some benchmark http://arstechnica.com/gaming/2016/02/vulkan-benchmarks-a-boost-for-amd-and-nvidia-but-theres-work-to-be-done/

gibbed commented 7 years ago

If you think so, feel free to implement a DX11 or DX12 backend yourself.

NuclearC commented 7 years ago

i didnt say i can do it better, but i want to understand why @benvanik removed DX11 backend from start

gibbed commented 7 years ago

Because DX11 was not meeting the demands of the emulator.

NuclearC commented 7 years ago

btw im getting 'Access violation reading location' exception on this line when using Vulkan on AMD driver:

return disp->CreateRenderPass(device, pCreateInfo, pAllocator, pRenderPass);

Thats the line 1653 in file 'trampoline.c' function vkCreateRenderPass which is called from CachedRenderPass(...) Here is the image: image

What can i do to fix this?