Closed jtmoulia closed 1 year ago
@xenodium thanks for the feedback! Many useful things to learn.
I'm still working through the context issue and will give you a heads up once it's ready for another review :bow:
(also, planning on flattening before merging once that's relevant)
@xenodium Hm I realized that I don't have a definite idea on which system prompt takes precedence -- I could use your feedback on Order of Precedence with two main options
I personally prefer the second option as it feels a bit strange to change the system prompt throughout a conversation (and the warnings provide the user some feedback if they do try it). But, curious which you prefer
Thanks for the changes!
I personally prefer the second option as it feels a bit strange to change the system prompt throughout a conversation (and the warnings provide the user some feedback if they do try it). But, curious which you prefer
Second w/ warning sounds good to me too. In addition, I wonder if we should consider only applying :system
if it occurs in the first block in the context? Similarly, it would feel a bit strange to change the system prompt throughout a conversation
.
ps. I forgot to check but don't we need to ensure the current block's :system
is never added (unless we aren't using :context
).
Thanks for the latest changes! I'm thinking we can likely do without the cleaning function if we only add items when necessary. Here's a patch https://gist.github.com/xenodium/b623cad9df4fa2b3076b4cb433dc602b
If you're keen to submit, I'm happy to approve and merge. I can follow-up with changes. Lemme know how you want to go about it.
ps. I got a bug in the current codebase. I'm using add-to-list, when I really shouldn't have. We don't want to remove duplicates from context. The patch above now uses push.
Cool! I like where you went with it, my approach was doing a lot of redundant looping.
I think it makes sense to land this as-is and then have you apply your changes; gives you a chance to touch the file last.
And, I think that means this is ready to go? 🚢
And, I think that means this is ready to go? 🚢
Merged! Thank you for the contribution.
Summary: This diff adds support for multiple different contexts using org-babel src blocks. The context is specified using the source block's
:context
param, which can be any string.Test Plan: If you put the source blocks below in an org file and execute the last block it should return a response similar to
sir/madam
as opposed tohuman
given the last block specified "lawyer" as opposed to "robot".Closes #120