xenodium / chatgpt-shell

A multi-llm Emacs shell (ChatGPT, Claude, Gemini) + editing integrations
https://xenodium.com
GNU General Public License v3.0
857 stars 76 forks source link

helm-mode compatibility #161

Closed vzaliva closed 11 months ago

vzaliva commented 11 months ago

When helm-mode is used, the system prompts menu looks weird:

image

Also, selecting the "Programming" prompt changes how it was shown initially:

image

xenodium commented 11 months ago

When helm-mode is used, the system prompts menu looks weird

Oh wow. This was a suprising bug, and likely a bug in helm itself.

No completion framework:

Screenshot 2023-12-05 at 09 29 38

ivy:

Screenshot 2023-12-05 at 09 30 05

vertico:

Screenshot 2023-12-05 at 09 32 32

helm:

Screenshot 2023-12-05 at 09 33 11

Looks like helm doesn't hide invisible text. Here's a reproducible snippet:

(completing-read "choose: " (list (concat
                                   "Hello "
                                   (propertize "DO NOT SHOW " 'invisible t)
                                   "world 1 ")
                                  (concat
                                   "Hello "
                                   (propertize "DO NOT SHOW " 'invisible t)
                                   "world 2 ")))

Could you file a bug on helm for this? In the meantime, I can look at working around this.

Also, selecting the "Programming" prompt changes how it was shown initially:

I'll need to investigate this one.

xenodium commented 11 months ago

Ok, both issues should now be fixed by https://github.com/xenodium/chatgpt-shell/commit/ba74172b2e112fe941719273030e46b3c22203fa Please update.

vzaliva commented 11 months ago

Tested and it seems to be working. This is fantastic! thanks!

xenodium commented 11 months ago

Glad to hear.