xenodium / chatgpt-shell

ChatGPT and DALL-E Emacs shells + Org babel 🦄 + a shell maker for other providers
https://xenodium.com
GNU General Public License v3.0
805 stars 72 forks source link

User should call `chatgpt-shell-swap-system-prompt` after calling ` chatgpt-shell-load-awesome-prompts` #226

Open casch-at opened 4 weeks ago

casch-at commented 4 weeks ago

https://github.com/xenodium/chatgpt-shell/blob/0efead292f053774bba3c0789370e8e383aa49ec/chatgpt-shell.el#L387-L416

I suggest removing L413-L416, and change the message at L412 to e.g. "Loaded awesome-chatgpt-prompts, call chatgpt-shell-swap-system-prompt to change your current chatgpt-shell-system-prompt"

xenodium commented 4 weeks ago

Thanks for filing. Could you share a bit more about the use-case? If loading awesome prompts, aren't you already highlighly likely to swap at the time of loading?

casch-at commented 3 weeks ago

Not necessarily, what if the user wants to automatically load them on each Emacs startup, than the user would get a warning about not being in chatgpt-shell-mode.

xenodium @.***> writes:

Thanks for filing. Could you share a bit more about the use-case? If loading awesome prompts, aren't you already highlighly likely to swap at the time of loading?

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.

xenodium commented 3 weeks ago

what if the user wants to automatically load them on each Emacs startup, than the user would get a warning about not being in chatgpt-shell-mode

If that's the main use-case we'd like to unblock, I'm thinking we should consider making chatgpt-shell-load-awesome-prompts a ilttle smarter to determine if invoked interactively to call swap. Would that work for you?

casch-at commented 3 weeks ago

Would that work for you?

Absolutely 👍🏻 I would be open to implementing that feature.

xenodium commented 3 weeks ago

Absolutely 👍🏻 I would be open to implementing that feature.

Sounds good. (called-interactively-p #'interactive) might help here.