search

xenodium / ready-player

GNU General Public License v3.0
136 stars 7 forks source link

Feature request: create git tags for the current numbered version and in the future for version bumps #12

Closed hab25 closed 3 months ago

hab25 commented 3 months ago

This will allow users to install tagged versions from MELPA Stable.

hab25 commented 3 months ago

Further, could it also be done for your other popular packages @xenodium? In particular, I also use https://github.com/xenodium/dwim-shell-command .

xenodium commented 3 months ago

Thanks for filling!

Reading the https://github.com/melpa/melpa docs, stable seems to be discouraged by the maintainers themselves:

Note that the MELPA maintainers do not use MELPA Stable themselves, and do not particularly recommend its use.

On the surface, it seems a little counterintuitive to commit to taking on a bit of extra work for a channel that's isn't recommended by the MELPA maintainers themselves?

Would you be interested in volunteering to help manage the stable release side of things for the packages you're keen on?

xenodium commented 3 months ago

Ok, so I've pushed version tags for both https://github.com/xenodium/ready-player and https://github.com/xenodium/dwim-shell-command. I'll give it a shot and see how it goes. Hope that helps.

hab25 commented 3 months ago

On the surface, it seems a little counterintuitive to commit to taking on a bit of extra work for a channel that's isn't recommended by the MELPA maintainers themselves?

I've seen that quote as well, and have chosen to disregard it. It's vague (i.e. is "do not particularly recommend its use" synonymous with "recommend against using it"?); IMO some rationale for such a recommendation should be added for that sentence to be useful.

Further, from my own experience, MELPA Stable has worked perfectly in providing me what I need, i.e. providing packages for those tagged versions and so I don't see any concrete reason to avoid it. (There may be reason to prefer following the latest git commit instead of the latest git tag in case the maintainer has stopped maintaining git tags, but that should not be confused as being MELPA Stable's responsibility)

Would you be interested in volunteering to help manage the stable release side of things for the packages you're keen on?

I'm not sure what this entails, but if it is anything that involves regularly reading the code or commit messages, then I wouldn't be interested only due to a consistent lack of time for the forseeable future, sorry.

However, it seems you were doing great with managing when to bump the version numbers, I assume in a way that related to stability. This request is just asking for a git tag to be created alongside whenever that happens; that should be, now that you've successfully created the first tag, mainly a matter of remembering to do it again when appropriate.

There may even exist some automation for it which I will share if I find.

I'll give it a shot and see how it goes. Hope that helps.

It does, thank you very much!

xenodium commented 3 months ago

IMO some rationale for such a recommendation should be added for that sentence to be useful.

I'm OK following the maintainer's recommendations. It's their gig.

This request is just asking for a git tag to be created alongside whenever that happens; that should be, now that you've successfully created the first tag, mainly a matter of remembering to do it again when appropriate.

Can only commit to best effort here. If the stable builds break or they require additinional, I'm afraid it'll be outside of scope of what I can volunteer/commit to.

It does, thank you very much!

Good to hear. Closing issue.