Play button now shown - Githubissues

xenodium / ready-player

GNU General Public License v3.0

136 stars 7 forks source link

Closed e40 closed 3 months ago

e40 commented 3 months ago

The play button looks like it's not installed. Is this an unreported dependency?

Screenshot 2024-07-05 at 2 01 40 PM

Emacs is 29.3 from emacsformacosx.com, which I've always used over the brew version.

Ideas?

xenodium commented 3 months ago

Ah, the package uses SF symbols on a macOS, but looks like you may need to enable it.

;; Enable rendering SF symbols on macOS.
(when (memq system-type '(darwin))
  (set-fontset-font t nil "SF Pro Display" nil 'append))

I should guard against that.

If that doesn't work, can you try setting to

(setq ready-player-play-icon "⏵")
(setq ready-player-open-externally-icon "➦")
(setq ready-player-stop-icon "■")

e40 commented 3 months ago

The 1st one didn't work, but the 2nd one did. Thanks.

xenodium commented 3 months ago

Good to know. Changed the defaults. Gonna close issue. Thanks!

e40 commented 3 months ago

Thanks, @xenodium! I "Upgraded" wit this:

(package-vc-install "https://github.com/xenodium/ready-player" :last-release)

and removed the special hack you gave me, works fine.

xenodium commented 3 months ago

Oh, handy. I've added :last-release to install notes.