search

xenohunter / bluesky-overhaul

UX improvements for Bluesky web app
https://bsky.app
MIT License
59 stars 2 forks source link

dist folder missing from latest build #3

Closed SelonNerias closed 1 year ago

SelonNerias commented 1 year ago

The latest build (v1.2.1) does not include the dist folder, which is needed to install the package.

It is fixable without dev support by grabbing the dist folder from the previous build and pasting it in the main folder.

xenohunter commented 1 year ago

Do you mean the .zip archive in the v1.2.1 release? I just downloaded and unpacked it, and the dist folder is there, along with the bundle.js file within it.

The source code, on the other hand, has never contained a compiled dist/bundle.js.

xenohunter commented 1 year ago

Additionally, I made sure that all commits would be built from now on. See the changes here: https://github.com/xenohunter/bluesky-overhaul/commit/54ccc59821f96fd1edfc1cb92a11de03157ef2ae.

Can I close the issue?

SelonNerias commented 1 year ago

Oops, I messed up the numbers. I meant v1.2.2. Yes, in the zip folder. Sorry for the mess up.

xenohunter commented 1 year ago

Hmm... I released v1.2.2 after you submitted this issue. And I'm positive that the archive contains all the needed files. Could you please try it again with clean slate? Download bluesky-overload-v1.2.2.zip from this release, unpack it, and check whether the extension installs.

Probably you're downloading the source code zip archive which indeed does not contain the dist folder (it shouldn't).

SelonNerias commented 1 year ago

Oh yeah your right, I probably did download the source code folder, my bad. I could have sworn I didn't, but the overhaul map certainly has the dist folder. Thanks for the assistance.

xenohunter commented 1 year ago

You're welcome!