Closed vlakoff closed 7 years ago
Providing the Window
as the first parameter is preferable.
The Refresh
after updating the title shouldn't be required. The text is updated before the initial render.
Suggestion for the text for the message boxes:
If you want to make those changes I'll merge them in.
Thanks!
I have applied your suggestions.
I asked about the window as first argument because:
Yeah, there's not a huge amount of difference between the two. Generally wherever possible it should be use the base Window
(Form), it just ensures the message box appears on top.
In Program.cs it's ok to leave them without, as we haven't created a Window yet.
I should probably change the UpdateForm
one to use the base form too.
Will make that change, and most likely will update the underlying Api, since there's more recent versions now.
Note I haven't tested these changes. A few points I can't say for sure:
MessageBox.Show
would benefit from having a window as 1st parameter.You might also want to adjust the texts as you wish.