search

xenolightning / AudioSwitcher_v1

Version 1 of Audio Switcher
Microsoft Public License
894 stars 90 forks source link

Hot Key Form - Device List wasn't taking user preference into consideration #2159

Closed noremacskich closed 7 years ago

noremacskich commented 7 years ago

On the Hot Key form, the list of devices was not filtering out any of the devices, based on user preference.

It should now only show active playback devices or capture devices, and depending on user preference, the disabled and or the disconnected devices.

This follows how the devices are being handled on the Playback and Recording pages

xenolightning commented 7 years ago

Oh! Nice enhancement! Cheers 👍

vlakoff commented 6 years ago

Hi @xenolightning, how about publishing a new release? A handful of great changes have been added since the last release :)

vlakoff commented 6 years ago

Having a second look at this, I'm unsure: wouldn't it be better to display all assigned hotkeys, even if the associated device has been disabled or is currently disconnected?

So the hotkeys overview would be exhaustive, and it would allow to cleanup/reassign keys.

xenolightning commented 6 years ago

@vlakoff I think I'm ok with that too, but there should probably be some way of distinguishing between active/disconnected/disabled devices in the menu, which could be a little difficult?

vlakoff commented 6 years ago

I think an additional column "active/disconnected/disabled" would add too much clutter.

I'd suggest graying out the text of the line, and adding a tooltip "Device is disabled"/"Device is disconnected".