xenomachina / kotlin-argparser

Easy to use and concise yet powerful and robust command line argument parsing for Kotlin
GNU Lesser General Public License v2.1
485 stars 33 forks source link

Added skip unknown arguments mode #38

Open lokkie opened 6 years ago

lokkie commented 6 years ago

If use cascade application running helps to proceed arguments for Application Runner and Single application

codecov-io commented 6 years ago

Codecov Report

Merging #38 into master will decrease coverage by 1.02%. The diff coverage is 28.57%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #38      +/-   ##
============================================
- Coverage     83.66%   82.64%   -1.03%     
  Complexity      136      136              
============================================
  Files            11       11              
  Lines           404      409       +5     
  Branches         81       83       +2     
============================================
  Hits            338      338              
- Misses           31       34       +3     
- Partials         35       37       +2
Impacted Files Coverage Δ Complexity Δ
...main/kotlin/com/xenomachina/argparser/ArgParser.kt 84.8% <28.57%> (-2.14%) 52 <0> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 386f22a...67144b1. Read the comment docs.

xenomachina commented 6 years ago

What is the purpose of this change? I don't know what "If use cascade application running helps to proceed arguments for Application Runner and Single application" means.

SpaceBison commented 6 years ago

Is there a chance that this PR will get merged?

xenomachina commented 6 years ago

@SpaceBison I asked a question in January that never got answered: what does "If use cascade application running helps to proceed arguments for Application Runner and Single application" mean?

Aside from that, the code has a couple of "todos" in it that would need to be resolved: "rewrite to correct count detection".

Is this intended to be a solution to issue #40? If so, I'd asked a question there that also never got answered.