search

xenon-middleware / xenon-cli

Perform files and jobs operations with Xenon library from command line
http://nlesc.github.io/Xenon/
Apache License 2.0
2 stars 3 forks source link

Using relative path in download and upload broken #37

Closed sverhoeven closed 7 years ago

sverhoeven commented 7 years ago

It is treating relative paths as absolute by prepending /.

It should prepend FileSystem.getEntryPath()

sverhoeven commented 7 years ago

Prepending of entry path is only needed when given path is relative. We need a method that can check if path is relative or absolute.

CLI has a Utils.isRelativeLocalPath() method, but this only works for local files.

We need a method that can check relativeness for each adaptor/filesystem.

sverhoeven commented 7 years ago

Blocked by https://github.com/NLeSC/Xenon/pull/516

sverhoeven commented 7 years ago

Blocked by https://github.com/NLeSC/Xenon/issues/519, after issue is fixed CLI should pass string as it got them and not try to fix relativiness.

sverhoeven commented 7 years ago

Progress see https://github.com/NLeSC/xenon-cli/tree/allow-relative-path-everywhere-37 branch

sverhoeven commented 7 years ago

Blocked by https://github.com/NLeSC/Xenon/pull/531

sverhoeven commented 7 years ago

Blocked by branch https://github.com/NLeSC/Xenon/tree/relative-file-tests merging to master

sverhoeven commented 7 years ago

Blockers are clear, remove to absolute path method from cli