xenon-middleware / xenon-grpc

Xenon grpc based server
Apache License 2.0
0 stars 1 forks source link

Change JobWithTimeout to contain instance of job #23

Closed jhidding closed 7 years ago

jhidding commented 7 years ago

This change would better fit the underlying OOP design.

sverhoeven commented 7 years ago
scheduler.wait_until_done(job=job, timeout=1000)

of OOP

job = scheduler.submit_batch_job(...)
job.wait_until_done(42)
jspaaks commented 7 years ago

At some point I had a discussion with Jason / @jmaassen about the OOP'ness (of Java Xenon) where this point came up. Our conclusion back then was that it makes more sense to limit OOPness to some toplevel objects.

In other words

jhidding commented 7 years ago

Ok, we'll keep it like it is.