xenondevs / Nova

Nova is a server-side modding framework for Paper servers that aims to streamline adding custom content like items, blocks, guis, and more, without client-side modifications, using resource pack tricks.
Other
371 stars 38 forks source link

Block break sound not playing for stone/sandstone/etc #325

Closed evilbocchi closed 8 months ago

evilbocchi commented 9 months ago

Agreements

Check for plugin incompatibilites

There are no other plugins running on my server.

Plugin Version, Server Software, Server Version

Nova: 0.16-alpha.2, Paper 392 (MC 1.20.4)

Nova Addons and Versions

-

Expected behavior

No response

Observed/Actual behavior

https://github.com/xenondevs/Nova/assets/71329833/1b5c7b1c-401c-475c-bcfe-75337f2e19f0

Steps to reproduce

  1. Break any block that produces the sound of a stone block being broken.

Server log

2024-01-22-10.log

Errors

No response

Additional context

Note: Even without the "Mna" addon and additional plugins the issue still occurs.

AMDBartek commented 9 months ago

Can confirm this issue on my Purpur-based (fork) 1.20.4 server using Nova v0.16-alpha.2. It's surprisingly more annoying than one would think even when just playing survival. I would greatly appreciate if it could be fixed, I may take a look at fixing it myself and make a PR, but it will be difficult to do so without knowing the exact source in Nova of the issue. It's not anything to do with an addon obviously so it must be something in Nova itself I guess? But I'm not exactly sure.

NichtStudioCode commented 9 months ago

but it will be difficult to do so without knowing the exact source in Nova of the issue

My guess is that this is caused by one of the SoundPatches not working properly with the new Minecraft version, but I don't really have the time to look into that at the moment.

AMDBartek commented 9 months ago

Thanks, I might take a closer look later and make a PR.

Edit: Can't really figure it out, this type of stuff isn't my strong suit but I will definitely take another look later again.

TheHuky commented 8 months ago

I have the same.