search

xenondevs / Nova

Nova is a server-side modding framework for Paper servers that aims to streamline adding custom content like items, blocks, guis, and more, without client-side modifications, using resource pack tricks.
Other
361 stars 37 forks source link

Can not Remove Ultimate Item Filter #371

Open P3YC1 opened 4 months ago

P3YC1 commented 4 months ago

Agreements

Check for plugin incompatibilites

There are no other plugins running on my server.

Plugin Version, Server Software, Server Version

Nova: 0.16 RC 2, Paper: git-Paper-463 (MC: 1.20.4)

Nova Addons and Versions

Jetpacks v0.1.12-RC.2, Logistics v0.2.8-RC.1, Machines v0.4.5-RC.4, Simple-Upgrades v1.3-RC.2, Vanilla Hammers v1.4-RC.2

Expected behavior

It is possible to take an Ultimate Item Filter out of a Basic Cable that is Attached to a Chest, while the Ultimate Item Filter has a damaged Crossbow inside it.

Observed/Actual behavior

It is NOT possible to take an Ultimate Item Filter out of a Basic Cable that is Attached to a Chest, while the Ultimate Item Filter has a damaged Crossbow inside it. It is stuck inside there as it would belong to the UI.

Steps to reproduce

  1. Get a Crossbow
  2. Shoot with it some time until it is damaged
  3. Get an Ultimate Item Filter, a Chest, and a Basic cable.
  4. Place the Crossbow inside the ultimate item filter.
  5. Place the chest, connect the cable to it, and place the ultimate item filter inside
  6. Try to take out the ultimate item filter

Server log

latest.log

Errors

No response

Additional context

No response

NichtStudioCode commented 4 months ago

Works fine for me

https://github.com/xenondevs/Nova/assets/51272202/616fa97a-7fc0-4ce7-9677-fb07a13fb68d

P3YC1 commented 4 months ago

Okay, so I did some more testing. It seems the issue occurs when you have the Item Filter in hand while trying to open the Config for the Cable. If you then look at the cable from a certain position, you can see the filter in your hand twitching, as you open the config for the Cable. If that happens, and you put the cable into the config, you can not retrieve it, aside from breaking the chest. It probably has something to do with the plugin trying to open two menus at the same time. If you can't reproduce it, I'll try to get a video of the bug happening.

NichtStudioCode commented 4 months ago

Yeah, I still can't reproduce it. It'd be great if you could send a video.

P3YC1 commented 4 months ago

https://github.com/xenondevs/Nova/assets/58711968/ff7f051c-96ec-4a4c-9fa6-f034b2baeabc