xenondevs / Nova

Nova is a server-side modding framework for Paper servers that aims to streamline adding custom content like items, blocks, guis, and more, without client-side modifications, using resource pack tricks.
Other
361 stars 37 forks source link

Resource pack do not load custom bow correctly #380

Closed CptbeffHeart closed 4 months ago

CptbeffHeart commented 4 months ago

Agreements

Check for plugin incompatibilites

There are no other plugins running on my server.

Plugin Version, Server Software, Server Version

Nova-0.16

Nova Addons and Versions

Nova-0.16

Expected behavior

When we register a new bow the overrides in the json file should look like something similar to that : https://pastebin.com/k0TTauMJ

Observed/Actual behavior

But it look like that : https://pastebin.com/T2j5a6Rx

Steps to reproduce

Register new bow in materials: "custom_bow": { "item": { "material": "bow", "models": { "item/bow/custom_bow/%s": [0, 3] } } }

Server log

.

Errors

No response

Additional context

The problem should probably come from xyz.xenondevs.nova.data.resources.builder.basepack.merger.ModelFileMerger There is only one model data possibility, but it need one specific for the bow and the shield (maybe some other ? )

NichtStudioCode commented 4 months ago

This is working as intended, there is just currently no built-in way to do custom bows or shields