xenondevs / Nova

Nova is a server-side modding framework for Paper servers that aims to streamline adding custom content like items, blocks, guis, and more, without client-side modifications, using resource pack tricks.
Other
361 stars 37 forks source link

When add ItemBehavior 'FireResistant' on Wearable armor, armor's texture not work #399

Closed lightindoeup closed 1 month ago

lightindoeup commented 1 month ago

Agreements

Check for plugin incompatibilites

There are no other plugins running on my server.

Plugin Version, Server Software, Server Version

Nova: 0.16.1, paper:git-Paper-497 (MC: 1.20.4)

Nova Addons and Versions

Logistics 0.2.8, Jetpacks 0.1.12, Machines 0.4.5, Simple Upgrades 1.3, Vanilla Hammers 1.4, custom addon made by me(for add armor)

Expected behavior

When equip armor, texture should be shown.(images when FireResistant has been removed, tested with official addon's texture) 2024-07-16_22 51 08 2024-07-16_22 51 04

Observed/Actual behavior

textures are not shown when equip armor, just appeared armor's icon on head. 2024-07-16_22 46 00 2024-07-16_22 46 02

Steps to reproduce

add ItemBehavior FireResistant on armor

Server log

latest.log

Errors

No response

Additional context

No response

NichtStudioCode commented 1 month ago

This works as intended, since fire-resistant is a client-side property that can only be mimicked by netherite-type items, but custom armor works via dyed leather armor, which creates a conflict between the two item types. This will resolve itself in 1.21 with the item data component changes.