search

xenondevs / Nova

Nova is a server-side modding framework for Paper servers that aims to streamline adding custom content like items, blocks, guis, and more, without client-side modifications, using resource pack tricks.
Other
370 stars 38 forks source link

[Bug] ghosting/performance issues #41

Closed MissGamerz closed 2 years ago

MissGamerz commented 2 years ago

Agreements

Plugin Version and Server Software

Nova: 0.6, Airplane version git-Airplane-92 (MC: 1.17.1) (Implementing API version 1.17.1-R0.1-SNAPSHOT) (Git: 5ed110b on HEAD)

Expected behavior

structures to load fine

Observed/Actual behavior

ghost structures are left behind due to chunks being unloaded then loaded again this happens mostly when a player logs off the server with no one else online for a while so the chunks get taken out of memory then logs back in again.

this results in a ghost structure plus the structure itself

structure in question Quarry

Steps to reproduce

place quarry set it going logout wait for a while (or restart the server if you cannot wait) log back in

Errors

non in console

Additional context

(suggestion): on chunk unload remove all armour stands completely like you do for plugin unload and when the chunks are loaded again load them back dynamically, this will fix this issue plus other issues at larger scales like ticking entities in unloaded chunks.

also maybe assigning textures to mushroom blocks instead of armour stands insides blocks (machines like furnaces) to cut down on entity count so the server/client doesnt have to load them all in which will also help the issue i'm having plus lag

MissGamerz commented 2 years ago

2021-10-15_10 30 01

NichtStudioCode commented 2 years ago

Your issue is missing the server version.

(suggestion): on chunk unload remove all armour stands completely like you do for plugin unload and when the chunks are loaded again load them back dynamically, this will fix this issue plus other issues at larger scales like ticking entities in unloaded chunks.

We're doing that.

also maybe assigning textures to mushroom blocks instead of armour stands insides blocks (machines like furnaces) to cut down on entity count so the server/client doesnt have to load them all in which will also help the issue i'm having plus lag

Mushroom blocks are not directional.

Please also check if the issue persists without any other plugins present on the server.

MissGamerz commented 2 years ago

Server version: This server is running Airplane version git-Airplane-92 (MC: 1.17.1) (Implementing API version 1.17.1-R0.1-SNAPSHOT) (Git: 5ed110b on HEAD)

i didnt think about the directional thing ah okay makes sense

MissGamerz commented 2 years ago

actually i think this was my fault not your plugin so i might close if i can recreate this problem with the way im thinking

MissGamerz commented 2 years ago

turns out this is snow with the quarry thats the problem

create a quarry in a snowy biome whilst mining and fully upgraded

NichtStudioCode commented 2 years ago

Fixed in 0.6.1