xenondevs / Nova

Nova is a server-side modding framework for Paper servers that aims to streamline adding custom content like items, blocks, guis, and more, without client-side modifications, using resource pack tricks.
Other
367 stars 38 forks source link

Mob Catcher Lags the server #449

Closed Nik0-0 closed 1 week ago

Nik0-0 commented 1 week ago

Agreements

Check for plugin incompatibilites

There are no other plugins running on my server.

Plugin Version, Server Software, Server Version

Nova: 0.17-alpha.14 . Purpur 1.21.1

Nova Addons and Versions

Vanilla-Hammers v1.5, SimpleUpgrades v1.4-alpha2, Logistics v0.2.9-alpha.3, Machines v0.4.6-alpha.8

Expected behavior

Mob should just pickup normally without lag

Observed/Actual behavior

Picking up any mob lags the whole server and causes issues

Steps to reproduce

  1. Get the Mob Catcher
  2. Click on any mob
  3. Observe the big TPS lag spike

Server log

https://mclo.gs/pSpQJBA

Errors

No response

Additional context

No response

Nik0-0 commented 1 week ago

Okay i think it may be caused by FancyDamageIndicator. Not sure yet

ByteZ1337 commented 1 week ago

Looks like the entity damage event is called with some very high damage amount when an entity is captured. Try switching the health mode in FancyDamageIndicator to NUMBER in the meantime as a temporary fix.

Nik0-0 commented 1 week ago

Yea for now i just removed the plugin since it was also creating bunch of text displays stuff even when set to NUMBER

ByteZ1337 commented 1 week ago

We'll remove the event call since it's no longer needed. That will also fix this issue. You should probably still report this to the FancyDamageIndicator author though because nothing stops another plugin from calling that event with some nonsensical amount of damage.