Storage unit becomes full for no reason

GabFran commented 4 hours ago

Agreements

[X] I am using an official build of Nova.
[X] I am running the latest version of Nova.
[X] I am using a server software supported by Nova
[X] I am running the latest version of my server software.
[X] I have checked for similar issues.

Check for plugin incompatibilites

There are no other plugins running on my server.

Plugin Version, Server Software, Server Version

Nova: 0.17-alpha.30; Paper: 1.21.1-119-master@7cd4f2c; MC: 1.21.1

Nova Addons and Versions

Simple-Upgrades v1.4-alpha.2, Machines v0.4.6-alpha.13, Logistics v0.2.9-alpha.5

Expected behavior

Storage units aren't supposed to randomly fill up to the 32-bit integer limit

Observed/Actual behavior

Sometimes, (apparently only after server restarts), storage units fill up to their maximum capacity (32-bit integer limit)

Steps to reproduce

I have not been able to consistently reproduce this bug, but it has only happened when storage units which contain items are outputting to an adjacent inventory, such as a chest or barrel.
It has happened after a server restart both times.
The storage unit must contain at least one item.
The console is spammed with an apparent loop for the affected storage units (it cites the items which are being multiplied multiple times in the error)

Server log

https://api.mclo.gs/1/raw/8bUh69a

Errors

[16:33:07] [DefaultDispatcher-worker-3/ERROR]: [Nova] An exception occurred trying to tick xyz.xenondevs.nova.world.block.tileentity.network.type.item.ItemNetworkGroup@8684125 in cluster NetworkCluster(uuid=deabb8f2-273e-4a7b-ab19-e77d134fd155, networks=[ItemNetwork(nodes={BlockPos(world=world, x=4, y=70, z=113)=MutableNetworkNodeConnection(node=StorageUnit(blockState=logistics:storage_unit[], pos=BlockPos(world=world, x=4, y=70, z=113), data={
  "itemHolder": {
    "channels": {NORTH=0, EAST=0, SOUTH=0, WEST=0, UP=0, DOWN=0}
    "connectionConfig": {NORTH=NONE, EAST=NONE, SOUTH=NONE, WEST=EXTRACT, UP=NONE, DOWN=INSERT}
    "containerConfig": {NORTH=045a8457-aa96-4feb-878a-39c069cbbde4, EAST=045a8457-aa96-4feb-878a-39c069cbbde4, SOUTH=045a8457-aa96-4feb-878a-39c069cbbde4, WEST=045a8457-aa96-4feb-878a-39c069cbbde4, UP=045a8457-aa96-4feb-878a-39c069cbbde4, DOWN=045a8457-aa96-4feb-878a-39c069cbbde4}
    "extractFilters": {}
    "extractPriorities": {NORTH=50, EAST=50, SOUTH=50, WEST=50, UP=50, DOWN=50}
    "insertFilters": {DOWN=xyz.xenondevs.nova.addon.logistics.item.itemfilter.TypeItemFilter@2b71246a}
    "insertPriorities": {NORTH=50, EAST=50, SOUTH=50, WEST=50, UP=50, DOWN=50}
  }
  "ownerUuid": (serialized) 013e67b1b3f6e94aba8c6a26f54cb75c53
  "persistent": {
    "amount": 0
    "type": ItemStack{AIR x 0}
  }

Additional context

No response

NichtStudioCode commented 4 hours ago

Is this a new issue with 0.17-alpha.30 or did it also happen previously?

NichtStudioCode commented 4 hours ago

I have also pushed a fix for something that may relate to this in 0.17-alpha.31, please tell me if you can still observe it under that version

GabFran commented 4 hours ago

This has happened in alpha 27 aswell

GabFran commented 4 hours ago

I have also pushed a fix for something that may relate to this in 0.17-alpha.31, please tell me if you can still observe it under that version

Will keep a look out for that, cheers.

xenondevs / Nova