search

xenonsb / Haxball-Room-Extension

Room search (originally by Raamyy) + AutoJoin + Admin shortcuts
GNU General Public License v3.0
11 stars 7 forks source link

Correct style for settings #3

Closed Wazarr94 closed 5 years ago

Wazarr94 commented 5 years ago

As of today, the choice for the plugins is really ugly. Could you do something a "Plugin settings" button like the rest of the buttons and open a menu like the settings menu already there ?

Thanks.

PS : There are also a lot of messages that get prompted in the console, any way to remove it ? Also, the search feature should not be saved once you refresh the page imo.

xenonsb commented 5 years ago

I'm working on a prettier version for the plugin choices - originally this was a smaller pet project with less options, but I see what you mean. It should come in the next version.

As for the console messages, I'll have the bulk of them removed.

The search feature saving the query terms was a design choice - most players I know have a preference for specific room types, so having it filter from the beginning would add convenience. For players who are not looking to join their regular rooms, they can choose to change the search bar - as it is implemented right now.

xenonsb commented 5 years ago

0.2.3 - Choice for plugin is now housed neatly in the same spot, with a new menu that opens.

Wazarr94 commented 5 years ago

The plugin is looking neat now. @xenonsb An extremely minor change I'm asking, could you add a space between the buttons in the nickname menu ? adding a margin-right of 5px is satisfying i think.

xenonsb commented 5 years ago

Space is added in 0.2.4, thanks!