mcclurmc
commented
12 years ago FYI @jonludlam
Open mcclurmc opened 12 years ago
mcclurmc
commented
12 years ago FYI @jonludlam
djs55
commented
12 years ago Perhaps we should copy the comments into the merge request, so we don't end up with a bunch of broken links in future...
On Fri, Aug 3, 2012 at 3:17 PM, Mike McClurg reply@reply.github.com wrote:
Jon Ludlam mentioned this to me today. It would be a good idea to start logging the pull request number and approver name in the merge commit. This way we can link our commit tree to the discussion on the pull request.
Reply to this email directly or view it on GitHub: https://github.com/xen-org/pull-request-manager/issues/10
Dave Scott
mcclurmc
commented
12 years ago Had considered doing that. If we're going through the trouble of logging this extra information, it probably wouldn't be much more work to copy in the comments as well. Only problem is that you lose context, since the comments are interleaved between commits and the code itself in some cases.
On Fri, Aug 3, 2012 at 4:27 PM, Dave Scott reply@reply.github.com wrote:
Perhaps we should copy the comments into the merge request, so we don't end up with a bunch of broken links in future...
On Fri, Aug 3, 2012 at 3:17 PM, Mike McClurg reply@reply.github.com wrote:
Jon Ludlam mentioned this to me today. It would be a good idea to start logging the pull request number and approver name in the merge commit. This way we can link our commit tree to the discussion on the pull request.
Reply to this email directly or view it on GitHub: https://github.com/xen-org/pull-request-manager/issues/10
Dave Scott
Reply to this email directly or view it on GitHub: https://github.com/xen-org/pull-request-manager/issues/10#issuecomment-7486177
djs55
commented
12 years ago Locked into the cloud, again! :)
On Fri, Aug 3, 2012 at 4:34 PM, Mike McClurg reply@reply.github.com wrote:
Had considered doing that. If we're going through the trouble of logging this extra information, it probably wouldn't be much more work to copy in the comments as well. Only problem is that you lose context, since the comments are interleaved between commits and the code itself in some cases.
On Fri, Aug 3, 2012 at 4:27 PM, Dave Scott reply@reply.github.com wrote:
Perhaps we should copy the comments into the merge request, so we don't end up with a bunch of broken links in future...
On Fri, Aug 3, 2012 at 3:17 PM, Mike McClurg reply@reply.github.com wrote:
Jon Ludlam mentioned this to me today. It would be a good idea to start logging the pull request number and approver name in the merge commit. This way we can link our commit tree to the discussion on the pull request.
Reply to this email directly or view it on GitHub: https://github.com/xen-org/pull-request-manager/issues/10
Dave Scott
Reply to this email directly or view it on GitHub: https://github.com/xen-org/pull-request-manager/issues/10#issuecomment-7486177
Reply to this email directly or view it on GitHub: https://github.com/xen-org/pull-request-manager/issues/10#issuecomment-7486355
Dave Scott
mcclurmc
commented
12 years ago LOL. Where's that "follow-me data" when you need it?
On Fri, Aug 3, 2012 at 4:36 PM, Dave Scott reply@reply.github.com wrote:
Locked into the cloud, again! :)
On Fri, Aug 3, 2012 at 4:34 PM, Mike McClurg reply@reply.github.com wrote:
Had considered doing that. If we're going through the trouble of logging this extra information, it probably wouldn't be much more work to copy in the comments as well. Only problem is that you lose context, since the comments are interleaved between commits and the code itself in some cases.
On Fri, Aug 3, 2012 at 4:27 PM, Dave Scott reply@reply.github.com wrote:
Perhaps we should copy the comments into the merge request, so we don't end up with a bunch of broken links in future...
On Fri, Aug 3, 2012 at 3:17 PM, Mike McClurg reply@reply.github.com wrote:
Jon Ludlam mentioned this to me today. It would be a good idea to start logging the pull request number and approver name in the merge commit. This way we can link our commit tree to the discussion on the pull request.
Reply to this email directly or view it on GitHub: https://github.com/xen-org/pull-request-manager/issues/10
Dave Scott
Reply to this email directly or view it on GitHub: https://github.com/xen-org/pull-request-manager/issues/10#issuecomment-7486177
Reply to this email directly or view it on GitHub: https://github.com/xen-org/pull-request-manager/issues/10#issuecomment-7486355
Dave Scott
Reply to this email directly or view it on GitHub: https://github.com/xen-org/pull-request-manager/issues/10#issuecomment-7486401
Jon Ludlam mentioned this to me today. It would be a good idea to start logging the pull request number and approver name in the merge commit. This way we can link our commit tree to the discussion on the pull request.