xenserver / status-report

Program that gathers data for xenserver host diagnostics
GNU Lesser General Public License v2.1
1 stars 9 forks source link

Fix mocking the `xen-bugtool` script in with Python 3.12 #90

Closed bernhardkaindl closed 7 months ago

bernhardkaindl commented 7 months ago

Fix for importing and mocking the xen-bugtool script as a module in Python 3.12:

Python3.12's mocker.patch() stopped supporting modules with a "-" in them.

Use "bugtool" as the module name instead of "xen-bugtool" to avoid this problem with the mocker.patch() function in Python 3.12.

The other commit in this PR for the dictionary file is needed to fix the spellcheck in CI.

codecov[bot] commented 7 months ago

Codecov Report

Merging #90 (7193884) into master (d0e569d) will increase coverage by 9%. Report is 10 commits behind head on master. The diff coverage is 100%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #90 +/- ## ====================================== + Coverage 88% 98% +9% ====================================== Files 18 18 Lines 2196 626 -1570 ====================================== - Hits 1939 615 -1324 + Misses 257 11 -246 ``` | [Files](https://app.codecov.io/gh/xenserver/status-report/pull/90?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=xenserver) | Coverage Δ | | |---|---|---| | [tests/unit/conftest.py](https://app.codecov.io/gh/xenserver/status-report/pull/90?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=xenserver#diff-dGVzdHMvdW5pdC9jb25mdGVzdC5weQ==) | `100% <100%> (ø)` | | | [tests/unit/test\_dump\_xapi\_rrds.py](https://app.codecov.io/gh/xenserver/status-report/pull/90?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=xenserver#diff-dGVzdHMvdW5pdC90ZXN0X2R1bXBfeGFwaV9ycmRzLnB5) | `100% <100%> (ø)` | | | [tests/unit/test\_output.py](https://app.codecov.io/gh/xenserver/status-report/pull/90?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=xenserver#diff-dGVzdHMvdW5pdC90ZXN0X291dHB1dC5weQ==) | `100% <100%> (ø)` | | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/xenserver/status-report/pull/90/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=xenserver) | [Flag](https://app.codecov.io/gh/xenserver/status-report/pull/90/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=xenserver) | Coverage Δ | | |---|---|---| | [python2.7](https://app.codecov.io/gh/xenserver/status-report/pull/90/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=xenserver) | `95% <100%> (+8%)` | :arrow_up: | | [python3.10.13](https://app.codecov.io/gh/xenserver/status-report/pull/90/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=xenserver) | `100% <100%> (+12%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=xenserver#carryforward-flags-in-the-pull-request-comment) to find out more.
coveralls commented 7 months ago

Pull Request Test Coverage Report for Build 8373887749

Details


Totals Coverage Status
Change from base Build 8373764528: 2.2%
Covered Lines: 625
Relevant Lines: 660

💛 - Coveralls