Allow repos to use Sonar to manage clean code, fix warnings

[bernhardkaindl]

Optionally allow repos to use Sonar to manage clean code and fix Sonar warnings

• Fix warnings from sonarlint and Sourcery
• Update configuration to be compatible with sonarcloud
• When the SONAR_TOKEN variable is added to a repo, sonarcloud can help to review pull requests.

  • It can (optionally) add a pull request comment that looks like this:

    Quality Gate Passed Quality Gate passed

Issues

• 0 New issues
• 0 Accepted issues (Remark for the PR: Accepted issues are like "WONTFIX" (acknowledged, but decided to not fix)

Measures

• 0 Security Hotspots

• 100.0% Coverage on New Code

• 0.0% Duplication on New Code

  Example PR comment by Sonarcloud: https://github.com/xenserver-next/status-report/pull/26#issuecomment-2016318433

• xen-bugtool's code is very clean at the moment, and this PR should help to test sonarcloud.

• Code coverage (also checked by sonarcloud for this PR) confirms that the changed lines in xen-bugtool and the unit tests are already covered by existing unit tests that cover 90% of the code.

• I checked if the change to disk_list() is indeed tested: Yes it is:

  • https://github.com/xenserver/status-report/blob/master/tests/unit/test_fs_funcs.py#L22

Here is the documentation for the used GitHub action: https://github.com/SonarSource/sonarcloud-github-action?tab=readme-ov-file

[codecov[bot]]

Codecov Report

Merging #98 (a76f121) into master (d0e569d) will increase coverage by 2%. Report is 16 commits behind head on master. The diff coverage is 100%.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #98 +/- ## ===================================== + Coverage 88% 91% +2% ===================================== Files 18 18 Lines 2196 2211 +15 ===================================== + Hits 1939 2017 +78 + Misses 257 194 -63 ``` | [Files](https://app.codecov.io/gh/xenserver/status-report/pull/98?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=xenserver) | Coverage Δ | | |---|---|---| | [tests/integration/test\_system\_load.py](https://app.codecov.io/gh/xenserver/status-report/pull/98?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=xenserver#diff-dGVzdHMvaW50ZWdyYXRpb24vdGVzdF9zeXN0ZW1fbG9hZC5weQ==) | `100% <100%> (ø)` | | | [tests/integration/test\_xenserver\_config.py](https://app.codecov.io/gh/xenserver/status-report/pull/98?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=xenserver#diff-dGVzdHMvaW50ZWdyYXRpb24vdGVzdF94ZW5zZXJ2ZXJfY29uZmlnLnB5) | `100% <ø> (ø)` | | | [tests/integration/utils.py](https://app.codecov.io/gh/xenserver/status-report/pull/98?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=xenserver#diff-dGVzdHMvaW50ZWdyYXRpb24vdXRpbHMucHk=) | `85% <ø> (ø)` | | | [tests/unit/conftest.py](https://app.codecov.io/gh/xenserver/status-report/pull/98?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=xenserver#diff-dGVzdHMvdW5pdC9jb25mdGVzdC5weQ==) | `100% <100%> (ø)` | | | [tests/unit/test\_main.py](https://app.codecov.io/gh/xenserver/status-report/pull/98?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=xenserver#diff-dGVzdHMvdW5pdC90ZXN0X21haW4ucHk=) | `100% <100%> (ø)` | | | [tests/unit/test\_output.py](https://app.codecov.io/gh/xenserver/status-report/pull/98?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=xenserver#diff-dGVzdHMvdW5pdC90ZXN0X291dHB1dC5weQ==) | `100% <100%> (ø)` | | | [xen-bugtool](https://app.codecov.io/gh/xenserver/status-report/pull/98?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=xenserver#diff-eGVuLWJ1Z3Rvb2w=) | `88% <100%> (+3%)` | :arrow_up: | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/xenserver/status-report/pull/98/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=xenserver) | [Flag](https://app.codecov.io/gh/xenserver/status-report/pull/98/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=xenserver) | Coverage Δ | | |---|---|---| | [python2.7](https://app.codecov.io/gh/xenserver/status-report/pull/98/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=xenserver) | `96% <100%> (+9%)` | :arrow_up: | | [python3.10.13](https://app.codecov.io/gh/xenserver/status-report/pull/98/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=xenserver) | `91% <100%> (+3%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=xenserver#carryforward-flags-in-the-pull-request-comment) to find out more.

[coveralls]

Pull Request Test Coverage Report for Build 8420807166

Details

• 23 of 23 (100.0%) changed or added relevant lines in 5 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage decreased (-4.6%) to 90.354%

---

Totals
Change from base Build 8419300538:	-4.6%
Covered Lines:	2042
Relevant Lines:	2260

---

💛 - Coveralls