xenserver / xe-guest-utilities

XenServer guest utilities for unix-like operating systems
BSD 2-Clause "Simplified" License
63 stars 57 forks source link

CP-42555:Remove out of date distro UT test case #148

Closed MinghuiHu closed 1 year ago

stormi commented 1 year ago

I would keep just a few test samples for very old distros. For example:

I agree it's probably not useful to keep them all, but just a few to try to make xe-linux-distribution robust against future changes. As I wrote in the other PR, it's not a matter of the distros being supported. It's rather a way to keep xe-linux-distribution detection capabilities at low cost.

xihuan-citrix commented 1 year ago

I would keep just a few test samples for very old distros. For example:

  • centos4
  • rhel5
  • sles9

I agree it's probably not useful to keep them all, but just a few to try to make xe-linux-distribution robust against future changes. As I wrote in the other PR, it's not a matter of the distros being supported. It's rather a way to keep xe-linux-distribution detection capabilities at low cost.

Hi @MinghuiHu , for the consideration of the robust of future changes, I suggest follow the rule, like keep at least one for each identify function identify_lsb for an EOL distro e.g. ubuntu18.04 identify_redhat for e.g. rhel5, centos4 identify_debian for debian_sarge identify_sles for sles9